Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fill to __all__ in ui and express.ui #1064

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Add fill to __all__ in ui and express.ui #1064

merged 2 commits into from
Jan 25, 2024

Conversation

wch
Copy link
Collaborator

@wch wch commented Jan 24, 2024

fill is currently imported into shiny.ui, but are not listed in the __all__ in that file. This PR:

  • Adds it to __all__ in shiny.ui
  • Imports it into shiny.express.ui and also adds them to __all__ in that file.

Note that this PR doesn't do the same for css. This is because css is meant for internal use.

@wch wch requested a review from cpsievert January 24, 2024 22:31
@wch wch changed the title Add css and fill to __all__ in ui and express.ui Add fill to __all__ in ui and express.ui Jan 24, 2024
Copy link
Collaborator

@cpsievert cpsievert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

shiny/ui/__init__.py Outdated Show resolved Hide resolved
@wch wch merged commit 585777c into main Jan 25, 2024
26 checks passed
@wch wch deleted the ui-css-fill branch January 25, 2024 03:59
schloerke added a commit that referenced this pull request Feb 13, 2024
* main: (33 commits)
  test: Test apps locally before deploying via pytest fixtures. (#1055)
  docs: Add ExtendedTask to API index (#1088)
  Fix `render.download` in Shiny Express, take 2 (#1085)
  Bump version to 0.7.0.9000
  Create two different api doc folders, one for Core and one for Express (#1053)
  chore: Pin black to version 23 (#1077)
  chore: Remove github link to shinylive (#1069)
  Bump version to 0.7.0
  Raise when `express.[input,output,session]` are used outside of Express app (#1067)
  Update dashboard template (#1056)
  chore: Remove many broken quartodoc links (#1061)
  Update {bslib} (#1062)
  Update docstrings for `expressify`, `hold`, and `render.express` (#1066)
  Add `fill` to `__all__` in `ui` and `express.ui` (#1064)
  Update shiny.js (#1059)
  docs(examples): Use refactored shinylive syntax (#1048)
  Update `shiny.js` (#1052)
  Add `express.ui.panel_title` (#1039)
  Don't run `effect`s created in a `MockSession` (#1049)
  Delete shiny/api-examples/Calc directory (#1044)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants